1
0
Fork 0
mirror of https://github.com/albfan/miraclecast.git synced 2025-02-12 21:31:58 +00:00
Commit graph

270 commits

Author SHA1 Message Date
David Herrmann
e2781c0a7a wifi: fix unused-result warning in log_ENOMEM()
Use log_vENOMEM() as we don't use the return-code.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-05-08 11:06:07 +02:00
David Herrmann
78cf818484 ctl: publish objects after parsing properties
Delay object-broadcasts so we first parse properties and then advertise
the objects. Otherwise, the caller will get almost empty objects which are
rather useless.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-04-23 12:30:20 +02:00
David Herrmann
d0a85ac46c ctl: parse wfd-subelements
Parse and show wfd-subelements.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-04-23 12:09:03 +02:00
David Herrmann
e624d5f81a wifi: add wfd-subelement properties
Allow dbus API users to read and modify WFD subelements.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-04-23 12:07:23 +02:00
David Herrmann
61db4a1d71 shl: fix shl_qstr_tokenize() quote parser
The parser is simply broken, fix it.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-29 12:51:40 +01:00
David Herrmann
9cb0a092c2 test: add valgrind memory checks
Copy over the "make memcheck" target from libshl. It runs the test-suite
again via valgrind and fails on any valgrind warnings. This is very useful
to find memory-leaks and invalid memory-accesses via the test-suite.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-28 12:48:10 +01:00
David Herrmann
729acb64ca test: don't leak sd_event in wpas tests
Correctly free the sd_event object we allocate, otherwise valgrind will
complain loudly.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-28 12:46:38 +01:00
David Herrmann
9fdda3b09a wpas: drain input-queues before signalling HUP
We _must_ aggressively drain input queues before we signal any HUP. There
might be queued messages that tell us important information about the
termination of wpa_supplicant.

Therefore, if a write() operation fails, we only signal HUP if the input
queues are empty. However, we cannot rely on EPOLLIN to be set, as the
input data might have arrived in between epoll_wait() and write(),
therefore, always run the non-blocking read() in case write() failed.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-28 12:40:17 +01:00
David Herrmann
fc02c0aaf6 test: make wpas tests safe to run in parallel
If you run "make check -jX", the test-suites will run in parallel. This
currently works fine, but someone might copy the wpas tests into something
more complex. In that case, the /tmp/XY files will be shared, which breaks
the test-suite. Therefore, use pid-suffixes so these files are exclusive
to the given test-process.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-28 12:39:50 +01:00
David Herrmann
4f55a01dc3 shl: remove custom offsetof helpers
Use the generic shl_container_of() instead of all the custom helpers.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-21 12:17:08 +01:00
David Herrmann
12bf5e026e shl: add ring-buffer helpers
The shl_ring helpers manage a dynamically-growing ring-buffer. We need
that for the following RTSP stream parsers, so add them to src/shared/.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-21 12:15:57 +01:00
David Herrmann
920f3ae250 shl: add u64 htable helpers
Add u64 helpers to shl_htable. They're fairly trivial and just copied from
unsigned-long, however, in case size_t is not 64bit wide we need to do
some trivial hashing.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-21 11:54:45 +01:00
David Herrmann
87b804c481 Remove old wifi code in miracled
The wifi code is now moved to miracle-wifid, no need to keep it anymore.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 13:31:01 +01:00
David Herrmann
89a268109e Remove old miraclectl
The miraclectl tool is no longer needed, remove it.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 13:23:58 +01:00
David Herrmann
6f9ab46448 Add new miracle-wifictl program
The miracle-wifictl program can be used to manage miracle-wifid. It
provides low-level P2P helpers, so the main miraclectl can skip thos.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 13:10:30 +01:00
David Herrmann
8ecc84d634 build: ignore test_wpas binary
This binary is build by "make check" and runs the wpas tests. Ignore it.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 13:09:39 +01:00
David Herrmann
18a5094bc0 Add new miracle-wifid daemon
The miracle-wifid daemon is a rewrite of the wifi-related parts of
miracled. Unlike miracled, we no longer integrate the wifi-part directly
into the core daemon. This way, we can easily replace the wifi-bridge with
other network managers once they gain P2P capabilities.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 13:08:25 +01:00
David Herrmann
b0b53f986c test: add wpas tests
Add extensive test-suite to verify our wpas-helpers work correctly.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 13:06:11 +01:00
David Herrmann
f34face988 shared: add wpa_supplicant bus-helpers
The wpas-helpers provide easy _asynchronous_ access to wpa_supplicant
control interfaces. Compared to the old wpa_ctrl_* stuff it's no longer
synchronous. Thus, it doesn't block our daemon while wpa_supplicant runs
some heavy work again..

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 13:03:32 +01:00
David Herrmann
cf53290608 build: ignore local wpa-supplicant binaries
As we need pretty recent wpas binaries, ignore them in the build tree.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 13:02:00 +01:00
David Herrmann
c6ac2b612a Change license to LGPL
Apply LGPL to all code that is not scheduled for removal.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 13:01:23 +01:00
David Herrmann
4f740dfffb shl: update shl dlist/util
Two new helpers to verify empty strings and list-link-state.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-19 12:36:49 +01:00
David Herrmann
bc69f5b27b shl: update shl files
Sync files with upstream libshl. See upstream commits for changes/fixes.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-14 19:44:53 +01:00
David Herrmann
06be8854c5 Update to new libsystemd API
The upstream API changed (isn't released, yet!). Update our code to use
the new systemd-211 API.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-03-12 11:53:57 +01:00
David Herrmann
3bd83f1572 res: add dbus policy file
An example policy file to use with miracled. Simply copy it into
/etc/dbus/system.d/.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-22 14:50:02 +01:00
David Herrmann
8c2f95257c Move gdhcp and miracle-dhcp to ./src/dhcp/
Use a common subdirectory for gdhcp so we can easily replace it once
sd-dhcp has server-side support.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-18 14:04:51 +01:00
David Herrmann
47539226cd Move shared helpers into ./src/shared/
Move all shared helpers into a separate subdirectory and rename to
libmiracle-shared.la.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-18 13:56:12 +01:00
David Herrmann
fc30d8b920 miracled: skip run-time device-monitor if running unmanaged
If we get ADD events from udev for a new link but run in unmanaged mode,
skip the event. It is fairly unlikely that another manager has already
started wpa_supplicant on it (and even if, it would be racy).

Hence, lets not support hotplugging in these cases until external managers
provide us a notification API.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 16:50:20 +01:00
David Herrmann
fe571fb729 miracled: try at most 5 times to connect to wpas
If, after 5 times (which is 1s), wpa_supplicant is still not reachable, we
now drop the link. This avoids hangup issues during wpas startup that
might happen from time to time.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 16:47:24 +01:00
David Herrmann
6a37cbe6b8 miracled: support managed wpa_supplicant
If miracled is spawned with --manage-wifi, we run our own copy of
wpa_supplicant on managed devices. This is meant for testing purposes
only. Hopefully, network-manages like NM or connman will provide a P2P API
at some time so we can switch. Until then, we allow the user to control
who is in charge of wpa_supplicant.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 16:42:54 +01:00
David Herrmann
5fb83c9159 shl: util: add _shl_sentinel_ marker for strjoin
This is very handy to catch wrong usage of shl_strjoin(). We now get a gcc
warning if the sentinel (NULL) is omitted.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 16:19:48 +01:00
David Herrmann
77aae60c52 miracle: add now() helper
This returns the current time in usec since EPOCH depending on the
clock-time.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 16:18:53 +01:00
David Herrmann
3db84c3822 miracle: fix miracle.h include protection
Move it to the top like we do in all other files..

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 16:18:22 +01:00
David Herrmann
b161687cb7 miracled: remove old --help text
These two entries are no longer valid, remove them.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 14:57:53 +01:00
David Herrmann
3a8e2ff9e0 miracled: add udev-based link enumeration/monitor
Allow users to tag devices as "miracle" via udev so they get picked up
automatically. We also add a generic "remove"-monitor so we correctly drop
links as they get unplugged. The wpa_supplicant notification is unreliable
so we want the proper udev-events here.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 14:37:25 +01:00
David Herrmann
14aa8368e6 miracled: send ScanStopped events
We should notify miraclectl about ScanStopped events so we can correctly
track active scans. If we don't do that, we would have to explicitly track
it on connect/disconnect/etc. commands, which seems cumbersome given the
undeterminisc actions they cause.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 13:45:50 +01:00
David Herrmann
533959633e miracled: add wifi-GO support
If we run as GO we need to support local AP events and dhcp-server
handling. Both was already supported by our code-base so simply hook it up
with miracled-wifi.

Note that this adds a severe restriction: we can only have a single
p2p-connection per interface. The wpa_supplicant events don't provide
enough information to associate the ifnames to devices.
But most drivers only support a single STA, anyway, so that's fine.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 13:45:40 +01:00
David Herrmann
f12a042306 dhcp: send comm-events as server
Add a gdhcp callback for server-side lease events. Then raise L: and R:
lines for each event we get so miracled can react to it.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 12:20:06 +01:00
David Herrmann
024ea8c733 dhcp: fix buffer-overflow for addresses
Fix trivial buffer-overflow which caused configuration overwrites.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-17 12:18:55 +01:00
David Herrmann
36da68594b build: update fdo links
We use "miracle" as project-name and for all links and tokens. The fancy
name stays "MiracleCast".

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-15 14:10:25 +01:00
David Herrmann
15aa4eeece res: update README
Add some proper information to the README file and point to the website
for more details.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 15:48:45 +01:00
David Herrmann
eaea59d324 res: add wpa.conf example
Add example file for wpa_supplicant so users can start testing.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 15:23:03 +01:00
David Herrmann
6fbd58e349 miraclectl: hook up connection API
Add commands for allow/reject/connect/disconnect and parse all events
properly. Notify the user of any important changes so they can react to
it.

Note that Peer.Connect() is currently not implemented and will stay this
way until we have the dhcp-server and wfd-source ready (or at least
planned).

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 15:06:24 +01:00
David Herrmann
01292905f0 miracled: send PropsChanged event on explicit peer-disconnect
If we explicitly call wifi_dev_disconnect(), no WIFI event is broadcasted,
so handle it manually and send a dbus event if it changed.

Note that we explicitly call into wifi even if the device is not connected
to kill any ongoing connection attempts.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 15:05:10 +01:00
David Herrmann
9212e72c52 miraclectl: fix crash during shutdown and scan-stop
Fix a NULL deref during shutdown if we try to stop a non-existant scan.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 14:34:13 +01:00
David Herrmann
dd3c8eac9c miracled: hook up peer-connection with dbus
Hook up the peer-dbus API with the underlying peer objects. This allows to
handle incoming requests and deal with connection issues.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 14:27:14 +01:00
David Herrmann
146cf0bdb0 miraclectl: stop scan on link-removal
If a link is removed, stop any pending interactive scan-tracking.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 14:13:41 +01:00
David Herrmann
1b1000b254 miraclectl: fix link/peer event formatting
Add colons so the event content is better readable on the CLI.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 14:13:01 +01:00
David Herrmann
12bf86c744 miraclectl: suppress useless error on scan-stop
If we stop a scan in an async-manner and the object is no longer around,
don't print an error. Only do that if the scan is stopped explicitly by
the user.

This allows us to correctly kill scans during link-removal in a follow-up
patch. In such cases, the scan-stop may fail of the dbus object has
already been removed.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 14:11:26 +01:00
David Herrmann
1c470e46a8 miraclectl: set default log-level to NOTICE
We currently suppress all log-messages except FATAL, which is not really
what we want. Initialize the log-level to NOTICE like the default for
shl_log is, too.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
2014-02-11 14:06:23 +01:00