external/srs
1
0
Fork 0
mirror of https://github.com/ossrs/srs.git synced 2025-03-09 15:49:59 +00:00
Code Issues Releases Wiki Activity

RTC: Refine DTLS code.

Browse source
This commit is contained in:
winlin 2020-06-24 18:03:09 +08:00
parent 6807299ed2
commit 0bf0a61401
3 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
trunk/src/app/srs_app_rtc_conn.cpp
View file

@ -153,8 +153,8 @@ srs_error_t SrsRtcDtls::initialize(SrsRequest* r)
return srs_error_wrap(err, "DTLS init"); return srs_error_wrap(err, "DTLS init");
} }
// TODO: FIXME: Support config by vhost to use RSA or ECDSA certificate. // TODO: FIXME: Leak for SSL_CTX* return by build_dtls_ctx.
if ((dtls = SSL_new(SrsDtls::instance()->get_dtls_ctx(r))) == NULL) { if ((dtls = SSL_new(SrsDtls::instance()->build_dtls_ctx())) == NULL) {
return srs_error_new(ERROR_OpenSslCreateSSL, "SSL_new dtls"); return srs_error_new(ERROR_OpenSslCreateSSL, "SSL_new dtls");
} }

3
trunk/src/app/srs_app_rtc_dtls.cpp
View file

@ -216,7 +216,7 @@ SrsDtls* SrsDtls::instance()
return _instance; return _instance;
} }
SSL_CTX* SrsDtls::get_dtls_ctx(SrsRequest* r) SSL_CTX* SrsDtls::build_dtls_ctx()
{ {
SSL_CTX* dtls_ctx; SSL_CTX* dtls_ctx;
#if OPENSSL_VERSION_NUMBER < 0x10002000L // v1.0.2 #if OPENSSL_VERSION_NUMBER < 0x10002000L // v1.0.2
@ -228,6 +228,7 @@ SSL_CTX* SrsDtls::get_dtls_ctx(SrsRequest* r)
#endif #endif
// Whether use ECDSA certificate. // Whether use ECDSA certificate.
// TODO: FIXME: Support config by vhost to use RSA or ECDSA certificate.
bool is_ecdsa = _srs_config->get_rtc_server_ecdsa(); bool is_ecdsa = _srs_config->get_rtc_server_ecdsa();
if (is_ecdsa) { // By ECDSA, https://stackoverflow.com/a/6006898 if (is_ecdsa) { // By ECDSA, https://stackoverflow.com/a/6006898
EC_KEY* eckey = EC_KEY_new(); EC_KEY* eckey = EC_KEY_new();

2
trunk/src/app/srs_app_rtc_dtls.hpp
View file

@ -48,7 +48,7 @@ public:
srs_error_t init(SrsRequest* r); srs_error_t init(SrsRequest* r);
public: public:
static SrsDtls* instance(); static SrsDtls* instance();
SSL_CTX* get_dtls_ctx(SrsRequest* r); SSL_CTX* build_dtls_ctx();
public: public:
std::string get_fingerprint() const; std::string get_fingerprint() const;
}; };