Squash: Fix ingest bug. Refine AUTHORS.

.github/ISSUE_TEMPLATE

@@ -7,6 +7,10 @@ assignees: ''
 
 ---
 
+> 注意：不提供以下信息的Issue会被直接删除(Please follow issue template, or we will delete it)
+
+> 注意：咨询和讨论请提交到SRS星球(Please ask question at) http://bbs.ossrs.net
+
 **描述(Description)**
 
 > 描述你遇到了什么问题(Please description your issue here)

README.md

@@ -74,14 +74,15 @@ Other important wiki:
 
 The [TOC(Technical Oversight Committee)](trunk/AUTHORS.md#toc) and [contributors](trunk/AUTHORS.md#contributors):
 
-* [Winlin](https://github.com/winlinvip): All areas of streaming server and documents.
-* [Wenjie](https://github.com/wenjiegit): The focus of his work is on the [HDS](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_DeliveryHDS) module.
-* [Runner365](https://github.com/runner365): The focus of his work is on the [SRT](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_SRTWiki) module.
-* [John](https://github.com/xiaozhihong): Focus on [WebRTC](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_WebRTC) module.
-* [B.P.Y(Bepartofyou)](https://github.com/Bepartofyou): Focus on [WebRTC](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_WebRTC) module.
-* [Lixin](https://github.com/xialixin): Focus on [GB28181](https://github.com/ossrs/srs/issues/1500) module.
-* [Mozhan](https://github.com/lipeng19811218): Focus on [WebRTC](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_WebRTC) module.
-* [Jinxue](https://github.com/chen-guanghua): Focus on [WebRTC](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_WebRTC) module.
+* [Winlin](https://github.com/winlinvip): Focus on [issues/PR](https://github.com/ossrs/srs/issues) and tests now.
+* [ZhaoWenjie](https://github.com/wenjiegit): Focus on [HDS](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_DeliveryHDS) module.
+* [ShiWei](https://github.com/runner365): Focus on [SRT](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_SRTWiki) module.
+* [XiaoZhihong](https://github.com/xiaozhihong): Focus on [WebRTC](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_WebRTC) module.
+* [WuPengqiang](https://github.com/Bepartofyou): Focus on [WebRTC](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_WebRTC) module.
+* [XiaLixin](https://github.com/xialixin): Focus on [GB28181](https://github.com/ossrs/srs/issues/1500) module.
+* [LiPeng](https://github.com/lipeng19811218): Focus on [WebRTC](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_WebRTC) module.
+* [ChenGuanghua](https://github.com/chen-guanghua): Focus on [WebRTC](https://github.com/simple-rtmp-server/srs/wiki/v4_CN_WebRTC) module.
+* [ChenHaibo](https://github.com/duiniuluantanqin): Focus on [GB28181](https://github.com/ossrs/srs/issues/1500) and [API](https://github.com/ossrs/srs/issues/1657) module.
 
 A big `THANK YOU` also goes to:
 

trunk/AUTHORS.md

@@ -2,25 +2,26 @@
 
 The TOC(Technical Oversight Committee):
 
-- `winlinvip<winlin@vip.126.com>`
-- `wenjiegit<zhaowenjie@tal.com>`
-- `xialixin<xialixin@kanzhun.com>`
-- `runner365<shiwei05@kuaishou.com>`
-- `xiaozhihong<hondaxiao@tencent.com>`
-- `Bepartofyou<pengqiang.wpq@alibaba-inc.com>`
-- `chen-guanghua<jinxue.cgh@alibaba-inc.com>`
-- `lipeng19811218<mozhan.lp@alibaba-inc.com>`
+- `Winlin<winlin@vip.126.com>`
+- `ZhaoWenjie<zhaowenjie@tal.com>`
+- `ShiWei<shiwei05@kuaishou.com>`
+- `XiaoZhihong<hondaxiao@tencent.com>`
+- `WuPengqiang<pengqiang.wpq@alibaba-inc.com>`
+- `XiaLixin<xialixin@kanzhun.com>`
+- `LiPeng<mozhan.lp@alibaba-inc.com>`
+- `ChenGuanghua<jinxue.cgh@alibaba-inc.com>`
+- `ChenHaibo<nmgchenhaibo@foxmail.com>`
 
 ## CONTRIBUTORS
 
 CONTRIBUTORS ordered by first contribution.
 
-* `winlinvip<winlin@vip.126.com>`
-* `winlinvip<winterserver@126.com>`
-* `winlinvip<chengli.ycl@alibaba-inc.com>`
-* `wenjiegit<zhaowenjie@tal.com>`
-* `wenjiegit<740936897@qq.com>`
-* `wenjiegit<wenjie.zhao@chinacache.com>`
+* `Winlin<winlin@vip.126.com>`
+* `Winlin<winterserver@126.com>`
+* `Winlin<chengli.ycl@alibaba-inc.com>`
+* `ZhaoWenjie<zhaowenjie@tal.com>`
+* `ZhaoWenjie<740936897@qq.com>`
+* `ZhaoWenjie<wenjie.zhao@chinacache.com>`
 * `xiangcheng.liu<liuxc0116@foxmail.com>`
 * `naijia.liu<youngcow@youngcow.net>`
 * `alcoholyi<alcoholyi@qq.com>`
@@ -69,33 +70,34 @@ CONTRIBUTORS ordered by first contribution.
 * `qiang.li<qiang.li@verycdn.com.cn>`
 * `HungMingWu<u9089000@gmail.com>`
 * `Himer<xishizhaohua@qq.com>`
-* `xialixin<xialixin@kanzhun.com>`
-* `xialixin<68469352@qq.com>`
-* `xialixin<xlx0625@163.com>`
-* `xialixin<xialx@yuntongxun.com>`
+* `XiaLixin<xialixin@kanzhun.com>`
+* `XiaLixin<68469352@qq.com>`
+* `XiaLixin<xlx0625@163.com>`
+* `XiaLixin<xialx@yuntongxun.com>`
 * `alphonsetai<tyh_123@163.com>`
 * `Michael.Ma<wnpllr@gmail.com>`
 * `lam2003<linmin3@yy.com>`
-* `runner365<shiwei05@kuaishou.com>`
-* `runner365<shi.weibd@hotmail.com>`
+* `ShiWei<shiwei05@kuaishou.com>`
+* `ShiWei<shi.weibd@hotmail.com>`
 * `XiaofengWang<wasphin@gmail.com>`
-* `xiaozhihong<hondaxiao@tencent.com>`
-* `xiaozhihong<xiaozhihong8@gmail.com>`
-* `xiaozhihong<xiaozhihong@huya.com>`
+* `XiaoZhihong<hondaxiao@tencent.com>`
+* `XiaoZhihong<xiaozhihong8@gmail.com>`
+* `XiaoZhihong<xiaozhihong@huya.com>`
 * `yanghuiwen<cainiaodj@qq.com>`
-* `Bepartofyou<309554135@qq.com>`
-* `Bepartofyou<pengqiang.wpq@alibaba-inc.com>`
+* `WuPengqiang<309554135@qq.com>`
+* `WuPengqiang<pengqiang.wpq@alibaba-inc.com>`
 * `l<22312935+lam2003@users.noreply.github.com>`
 * `xfalcon<x-falcon@users.noreply.github.com>`
-* `chen-guanghua<jinxue.cgh@alibaba-inc.com>`
-* `chen-guanghua<chengh_math@126.com>`
-* `lipeng19811218<mozhan.lp@alibaba-inc.com>`
-* `lipeng19811218<lipeng19811218@gmail.com>`
+* `ChenGuanghua<jinxue.cgh@alibaba-inc.com>`
+* `ChenGuanghua<chengh_math@126.com>`
+* `LiPeng<mozhan.lp@alibaba-inc.com>`
+* `LiPeng<lipeng19811218@gmail.com>`
 * `yajun18<yajun18@staff.sina.com.cn>`
 * `liulichuan<liulichuan@kuaishou.com>`
 * `yapingcat<caoyapingneu@163.com>`
 * `chenchengbin<chenchengbin@yy.com>`
-* `duiniuluantanqin<nmgchenhaibo@foxmail.com>`
+* `ChenHaibo<495810242@qq.com>`
+* `ChenHaibo<nmgchenhaibo@foxmail.com>`
 * `jasongwq<jasongwq@gmail.com>`
 * `yinjiaoyuan<yinjiaoyuan@163.com>`
 * `PieerePi<pihuibin@hotmail.com>`
@@ -107,4 +109,6 @@ CONTRIBUTORS ordered by first contribution.
 * `stone<bluestn@163.com>`
 * `cfw11<34058899+cfw11@users.noreply.github.com>`
 * `Hung-YiChen<gaod.chen@gmail.com>`
-* `long<liyalong12345@126.com>`
+* `long<liyalong12345@126.com>`
+* `matthew1838<77285055+matthew1838@users.noreply.github.com>`
+* `rise<rise.worlds@outlook.com>`

trunk/scripts/new_authors.sh

@@ -12,5 +12,5 @@ for author in $authors; do
   username=$(echo $author |awk -F '@' '{print $1}')
   grep $username $AFILE 1>/dev/null 2>/dev/null && continue;
 
-  git log -1 --author="$author" --format='%an<%ae>'| sed 's/ //g'
+  echo "* $(git log -1 --author="$author" --format='`%an<%ae>`'| sed 's/ //g')"
 done

trunk/src/app/srs_app_config.cpp

@@ -3526,7 +3526,7 @@ srs_error_t SrsConfig::parse_argv(int& i, char** argv)
 void SrsConfig::print_help(char** argv)
 {
     printf(
-           "%s, %s, %s, created by %s\n\n"
+           "%s, %s, %s, created by %sand %s\n\n"
            "Usage: %s <-h?vVgG>|<[-t] -c filename>\n"
            "Options:\n"
            "   -?, -h              : Show this help and exit 0.\n"
@@ -3539,7 +3539,7 @@ void SrsConfig::print_help(char** argv)
            "   %s -t -c %s\n"
            "   %s -c %s\n",
            RTMP_SIG_SRS_SERVER, RTMP_SIG_SRS_URL, RTMP_SIG_SRS_LICENSE,
-           RTMP_SIG_SRS_AUTHORS,
+           RTMP_SIG_SRS_AUTHORS, SRS_CONSTRIBUTORS,
            argv[0], argv[0], argv[0], SRS_CONF_DEFAULT_COFNIG_FILE,
            argv[0], SRS_CONF_DEFAULT_COFNIG_FILE);
 }

trunk/src/app/srs_app_process.cpp

@@ -153,6 +153,30 @@ srs_error_t srs_redirect_output(string from_file, int to_fd)
     return err;
 }
 
+srs_error_t SrsProcess::redirect_io()
+{
+    srs_error_t err = srs_success;
+
+    // for the stdout, ignore when not specified.
+    // redirect stdout to file if possible.
+    if ((err = srs_redirect_output(stdout_file, STDOUT_FILENO)) != srs_success) {
+        return srs_error_wrap(err, "redirect stdout");
+    }
+
+    // for the stderr, ignore when not specified.
+    // redirect stderr to file if possible.
+    if ((err = srs_redirect_output(stderr_file, STDERR_FILENO)) != srs_success) {
+        return srs_error_wrap(err, "redirect stderr");
+    }
+
+    // No stdin for process, @bug https://github.com/ossrs/srs/issues/1592
+    if ((err = srs_redirect_output("/dev/null", STDIN_FILENO)) != srs_success) {
+        return srs_error_wrap(err, "redirect /dev/null");
+    }
+
+    return err;
+}
+
 srs_error_t SrsProcess::start()
 {
     srs_error_t err = srs_success;
@@ -182,24 +206,13 @@ srs_error_t SrsProcess::start()
         // ignore the SIGINT and SIGTERM
         signal(SIGINT, SIG_IGN);
         signal(SIGTERM, SIG_IGN);
-
-        // for the stdout, ignore when not specified.
-        // redirect stdout to file if possible.
-        if ((err = srs_redirect_output(stdout_file, STDOUT_FILENO)) != srs_success) {
-            return srs_error_wrap(err, "redirect output");
+        
+        // redirect standard I/O, if it failed, output error to stdout, and exit child process.
+        if ((err = redirect_io()) != srs_success) {
+            fprintf(stdout, "child process error, %s\n", srs_error_desc(err).c_str());
+            exit(-1);
         }
         
-        // for the stderr, ignore when not specified.
-        // redirect stderr to file if possible.
-        if ((err = srs_redirect_output(stderr_file, STDERR_FILENO)) != srs_success) {
-            return srs_error_wrap(err, "redirect output");
-        }
-
-        // No stdin for process, @bug https://github.com/ossrs/srs/issues/1592
-        if ((err = srs_redirect_output("/dev/null", STDIN_FILENO)) != srs_success) {
-            return srs_error_wrap(err, "redirect input");
-        }
-
         // should never close the fd 3+, for it myabe used.
         // for fd should close at exec, use fnctl to set it.
         

trunk/src/app/srs_app_process.hpp

@@ -53,6 +53,9 @@ public:
     // @param argv the argv for binary path, the argv[0] generally is the binary.
     // @remark the argv[0] must be the binary.
     virtual srs_error_t initialize(std::string binary, std::vector<std::string> argv);
+private:
+    // Redirect standard I/O.
+    virtual srs_error_t redirect_io();
 public:
     // Start the process, ignore when already started.
     virtual srs_error_t start();

trunk/src/main/srs_main_server.cpp

@@ -119,8 +119,7 @@ srs_error_t do_main(int argc, char** argv)
     
     // config already applied to log.
     srs_trace2(TAG_MAIN, "%s, %s", RTMP_SIG_SRS_SERVER, RTMP_SIG_SRS_LICENSE);
-    srs_trace("authors: %s", RTMP_SIG_SRS_AUTHORS);
-    srs_trace("contributors: %s", SRS_CONSTRIBUTORS);
+    srs_trace("authors: %sand %s", RTMP_SIG_SRS_AUTHORS, SRS_CONSTRIBUTORS);
     srs_trace("cwd=%s, work_dir=%s, build: %s, configure: %s, uname: %s, osx: %d",
         _srs_config->cwd().c_str(), cwd.c_str(), SRS_BUILD_DATE, SRS_USER_CONFIGURE, SRS_UNAME, SRS_OSX_BOOL);
     srs_trace("configure detail: " SRS_CONFIGURE);