1
0
Fork 0
mirror of https://github.com/ossrs/srs.git synced 2025-03-09 15:49:59 +00:00

HLS: Ignore empty NALU to avoid error. v6.0.65 (#3750)

For the DJI M30, there is a bug where empty NALU packets with a size of
zero are causing issues with HLS streaming. This bug leads to random
unpublish events due to the SRS disconnecting the connection for the HLS
module when it fails to handle empty NALU packets.

To address this bug, we have patched the system to ignore any empty NALU
packets with a size of zero. Additionally, we have created a tool in the
srs-bench to replay pcapng files captured by tcpdump or Wireshark. We
have also added utest using mprotect and asan to detect any memory
corruption.

It is important to note that this bug has been fixed in versions 4.0.271
6477f31004 and 5.0.170
939f6b484b. This patch specifically
addresses the issue in SRS 6.0.

Please be aware that there is another commit related to this bug that
partially fixes the issue but still leaves a small problem for asan to
detect memory corruption. This commit,
577cd299e1, only ignores empty NALU
packets but still reads beyond the memory.

---------

Co-authored-by: chundonglinlin <chundonglinlin@163.com>
This commit is contained in:
Winlin 2023-08-02 22:49:49 +08:00 committed by GitHub
parent e19efe0bcd
commit 73dd8af4c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
182 changed files with 46111 additions and 3914 deletions

View file

@ -1,4 +1,3 @@
//go:build appengine
// +build appengine
package colorable

View file

@ -1,5 +1,5 @@
//go:build !windows && !appengine
// +build !windows,!appengine
// +build !windows
// +build !appengine
package colorable

View file

@ -1,5 +1,5 @@
//go:build windows && !appengine
// +build windows,!appengine
// +build windows
// +build !appengine
package colorable

View file

@ -1,4 +1,3 @@
//go:build android
// +build android
package isatty

View file

@ -1,4 +1,3 @@
//go:build (darwin || freebsd || openbsd || netbsd || dragonfly) && !appengine
// +build darwin freebsd openbsd netbsd dragonfly
// +build !appengine

View file

@ -1,4 +1,3 @@
//go:build appengine || js || nacl
// +build appengine js nacl
package isatty

View file

@ -1,5 +1,5 @@
//go:build solaris && !appengine
// +build solaris,!appengine
// +build solaris
// +build !appengine
package isatty

View file

@ -1,4 +1,3 @@
//go:build (linux || aix) && !appengine && !android
// +build linux aix
// +build !appengine
// +build !android

View file

@ -1,5 +1,5 @@
//go:build windows && !appengine
// +build windows,!appengine
// +build windows
// +build !appengine
package isatty