From 8de89f3f37a5054e516af4878e59ea94b9aee583 Mon Sep 17 00:00:00 2001 From: winlin Date: Thu, 2 Apr 2020 12:28:47 +0800 Subject: [PATCH] Add TODO for SRTP-GCM for RTC --- trunk/src/app/srs_app_dtls.cpp | 4 ++++ trunk/src/app/srs_app_rtc_conn.cpp | 3 +++ 2 files changed, 7 insertions(+) diff --git a/trunk/src/app/srs_app_dtls.cpp b/trunk/src/app/srs_app_dtls.cpp index 4985af58b..5022dc668 100644 --- a/trunk/src/app/srs_app_dtls.cpp +++ b/trunk/src/app/srs_app_dtls.cpp @@ -123,6 +123,10 @@ void SrsDtls::init() srs_assert(SSL_CTX_use_PrivateKey(dtls_ctx, dtls_private_key) == 1); srs_assert(SSL_CTX_set_cipher_list(dtls_ctx, "ALL:!ADH:!LOW:!EXP:!MD5:@STRENGTH") == 1); + + // TODO: Maybe we can use SRTP-GCM in future. + // @see https://bugs.chromium.org/p/chromium/issues/detail?id=713701 + // @see https://groups.google.com/forum/#!topic/discuss-webrtc/PvCbWSetVAQ srs_assert(SSL_CTX_set_tlsext_use_srtp(dtls_ctx, "SRTP_AES128_CM_SHA1_80") == 0); // Server will send Certificate Request. diff --git a/trunk/src/app/srs_app_rtc_conn.cpp b/trunk/src/app/srs_app_rtc_conn.cpp index 41b72777d..a85046a7d 100644 --- a/trunk/src/app/srs_app_rtc_conn.cpp +++ b/trunk/src/app/srs_app_rtc_conn.cpp @@ -303,6 +303,9 @@ srs_error_t SrsDtlsSession::srtp_send_init() srtp_policy_t policy; bzero(&policy, sizeof(policy)); + // TODO: Maybe we can use SRTP-GCM in future. + // @see https://bugs.chromium.org/p/chromium/issues/detail?id=713701 + // @see https://groups.google.com/forum/#!topic/discuss-webrtc/PvCbWSetVAQ srtp_crypto_policy_set_aes_cm_128_hmac_sha1_80(&policy.rtp); srtp_crypto_policy_set_aes_cm_128_hmac_sha1_80(&policy.rtcp);