1
0
Fork 0
mirror of https://github.com/ossrs/srs.git synced 2025-03-09 15:49:59 +00:00

ASAN: Support coroutine context switching and stack tracing (#4153)

For coroutine, we should use `__sanitizer_start_switch_fiber` which
similar to`VALGRIND_STACK_REGISTER`, see
https://github.com/google/sanitizers/issues/189#issuecomment-1346243598
for details. If not fix this, asan will output warning:

```
==72269==WARNING: ASan is ignoring requested __asan_handle_no_return: stack type: default top: 0x00016f638000; bottom 0x000106bec000; size: 0x000068a4c000 (1755627520)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
```

It will cause asan failed to get the stack, see
`research/st/asan-switch.cpp` for example:

```
==71611==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x000103600733 at pc 0x0001009d3d7c bp 0x000100b4bd40 sp 0x000100b4bd38
WRITE of size 1 at 0x000103600733 thread T0
    #0 0x1009d3d78 in foo(void*) asan-switch.cpp:13
```

After fix this issue, it should provide the full stack when crashing:

```
==73437==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x000103300733 at pc 0x000100693d7c bp 0x00016f76f550 sp 0x00016f76f548
WRITE of size 1 at 0x000103300733 thread T0
    #0 0x100693d78 in foo(void*) asan-switch.cpp:13
    #1 0x100693df4 in main asan-switch.cpp:23
    #2 0x195aa20dc  (<unknown module>)
```

For primordial coroutine, if not set the stack by
`st_set_primordial_stack`, then the stack is NULL and asan can't get the
stack tracing. Note that it's optional and only make it fail to display
the stack information, no other errors.

---

Co-authored-by: john <hondaxiao@tencent.com>
This commit is contained in:
Winlin 2024-08-22 17:12:39 +08:00 committed by GitHub
parent 55610cf689
commit 8f48a0e2d1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
15 changed files with 236 additions and 15 deletions

View file

@ -253,6 +253,13 @@ srs_error_t do_main(int argc, char** argv, char** envp)
int main(int argc, char** argv, char** envp)
{
#ifdef SRS_SANITIZER
// Setup the primordial stack for st. Use the current variable address as the stack top.
// This is not very accurate but sufficient.
void* p = NULL;
srs_set_primordial_stack(&p);
#endif
srs_error_t err = do_main(argc, argv, envp);
if (err != srs_success) {

View file

@ -9,6 +9,7 @@
#include <st.h>
#include <fcntl.h>
#include <sys/socket.h>
#include <sys/resource.h>
#include <netdb.h>
using namespace std;
@ -38,6 +39,23 @@ bool srs_st_epoll_is_supported(void)
}
#endif
#ifdef SRS_SANITIZER
void srs_set_primordial_stack(void* stack_top)
{
if (!stack_top) {
return;
}
struct rlimit limit;
if (getrlimit (RLIMIT_STACK, &limit) != 0) {
return;
}
void* stack_bottom = (char*)stack_top - (uint64_t)limit.rlim_cur;
st_set_primordial_stack(stack_top, stack_bottom);
}
#endif
srs_error_t srs_st_init()
{
#ifdef __linux__

View file

@ -20,6 +20,12 @@ typedef void* srs_thread_t;
typedef void* srs_cond_t;
typedef void* srs_mutex_t;
#ifdef SRS_SANITIZER
// Setup the primordial stack for asan detecting.
void srs_set_primordial_stack(void* stack_top);
#endif
// Initialize ST, requires epoll for linux.
extern srs_error_t srs_st_init();
// Destroy ST, free resources for asan detecting.