From d0bc0884d1cf5927473dc97b320af0b587b234cd Mon Sep 17 00:00:00 2001 From: winlin Date: Sun, 27 Jul 2014 11:57:08 +0800 Subject: [PATCH] refine rtmp client, add comments for the dumps_packets() --- trunk/src/app/srs_app_source.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/trunk/src/app/srs_app_source.cpp b/trunk/src/app/srs_app_source.cpp index 3cba64bbf..87702842a 100644 --- a/trunk/src/app/srs_app_source.cpp +++ b/trunk/src/app/srs_app_source.cpp @@ -212,8 +212,13 @@ int SrsMessageQueue::dump_packets(int max_count, SrsSharedPtrMessage** pmsgs, in av_start_time = last->header.timestamp; if (count == (int)msgs.size()) { + // the pmsgs is big enough and clear msgs at most time. msgs.clear(); } else { + // erase some vector elements may cause memory copy, + // maybe can use more efficient vector.swap to avoid copy. + // @remark for the pmsgs is big enough, for instance, SYS_MAX_PLAY_SEND_MSGS 128, + // the rtmp play client will get 128msgs once, so this branch rarely execute. msgs.erase(msgs.begin(), msgs.begin() + count); }