1
0
Fork 0
mirror of https://github.com/ossrs/srs.git synced 2025-02-13 20:01:56 +00:00

explicitly enable nack, for firefox (#2373)

This commit is contained in:
Haibo Chen 2021-07-24 20:47:34 +08:00 committed by GitHub
parent 1c80b529f8
commit fb73d42c38
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -3115,6 +3115,10 @@ srs_error_t SrsRtcConnection::negotiate_play_capability(SrsRtcUserConfig* ruc, s
// @see https://github.com/ossrs/srs/issues/2370 // @see https://github.com/ossrs/srs/issues/2370
track->extmaps_.clear(); track->extmaps_.clear();
// We should clear the rtcp_fbs of source(publisher).
// @see https://github.com/ossrs/srs/issues/2371
track->media_->rtcp_fbs_.clear();
// Use remote/source/offer PayloadType. // Use remote/source/offer PayloadType.
track->media_->pt_of_publisher_ = track->media_->pt_; track->media_->pt_of_publisher_ = track->media_->pt_;
track->media_->pt_ = remote_payload.payload_type_; track->media_->pt_ = remote_payload.payload_type_;
@ -3131,7 +3135,7 @@ srs_error_t SrsRtcConnection::negotiate_play_capability(SrsRtcUserConfig* ruc, s
uint32_t publish_ssrc = track->ssrc_; uint32_t publish_ssrc = track->ssrc_;
vector<string> rtcp_fb; vector<string> rtcp_fb;
track->media_->rtcp_fbs_.swap(rtcp_fb); remote_payload.rtcp_fb_.swap(rtcp_fb);
for (int j = 0; j < (int)rtcp_fb.size(); j++) { for (int j = 0; j < (int)rtcp_fb.size(); j++) {
if (nack_enabled) { if (nack_enabled) {
if (rtcp_fb.at(j) == "nack" || rtcp_fb.at(j) == "nack pli") { if (rtcp_fb.at(j) == "nack" || rtcp_fb.at(j) == "nack pli") {