From 3b45b38aeb71c778e64553079bd0095db85718d1 Mon Sep 17 00:00:00 2001 From: Phil Elwell Date: Tue, 12 Nov 2019 16:41:21 +0000 Subject: [PATCH 162/552] drm/v3d: Plug dma_fence leak The irq_fence and done_fence are given a reference that is never released. The necessary dma_fence_put()s seem to have been deleted in error in an earlier commit. Fixes: 0b73676836b2 ("drm/v3d: Clock V3D down when not in use.") Signed-off-by: Phil Elwell --- drivers/gpu/drm/v3d/v3d_gem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 13bd2e148f3f..f0ea76bd6693 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -412,6 +412,9 @@ v3d_job_free(struct kref *ref) } xa_destroy(&job->deps); + dma_fence_put(job->irq_fence); + dma_fence_put(job->done_fence); + v3d_clock_up_put(v3d); kfree(job); -- 2.33.0