From 9afe724a18da7c0136d9118e178f8f53c4a164cf Mon Sep 17 00:00:00 2001 From: Dave Stevenson Date: Thu, 26 Oct 2023 18:05:09 +0100 Subject: [PATCH 0709/1002] drm/vc4: Drop WARN for HVS FIFOs not being empty The reset condition for the EMPTY flag in DISPSTATx is 0, so seeing as we've just reset the pipeline there is no guarantee that the flag will denote empty if it hasn't been enabled. Drop the WARN. Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_hvs.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c index 13ea95d5f219..821bb996bbf1 100644 --- a/drivers/gpu/drm/vc4/vc4_hvs.c +++ b/drivers/gpu/drm/vc4/vc4_hvs.c @@ -1005,10 +1005,6 @@ static void __vc4_hvs_stop_channel(struct vc4_hvs *hvs, unsigned int chan) SCALER_DISPSTATX_MODE) != SCALER_DISPSTATX_MODE_DISABLED); - WARN_ON_ONCE((HVS_READ(SCALER_DISPSTATX(chan)) & - (SCALER_DISPSTATX_FULL | SCALER_DISPSTATX_EMPTY)) != - SCALER_DISPSTATX_EMPTY); - out: drm_dev_exit(idx); } -- 2.44.0