mirror of
				https://github.com/Ysurac/openmptcprouter.git
				synced 2025-03-09 15:40:20 +00:00 
			
		
		
		
	
		
			
				
	
	
		
			93 lines
		
	
	
	
		
			3.5 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			93 lines
		
	
	
	
		
			3.5 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From 431dbdb7301aad021ebfd89a4f6177b7c25f3322 Mon Sep 17 00:00:00 2001
 | 
						|
From: Ram Chandrasekar <rkumbako@codeaurora.org>
 | 
						|
Date: Mon, 7 May 2018 11:54:08 -0600
 | 
						|
Subject: [PATCH 152/726] drivers: thermal: step_wise: add support for
 | 
						|
 hysteresis
 | 
						|
 | 
						|
Step wise governor increases the mitigation level when the temperature
 | 
						|
goes above a threshold and will decrease the mitigation when the
 | 
						|
temperature falls below the threshold. If it were a case, where the
 | 
						|
temperature hovers around a threshold, the mitigation will be applied
 | 
						|
and removed at every iteration. This reaction to the temperature is
 | 
						|
inefficient for performance.
 | 
						|
 | 
						|
The use of hysteresis temperature could avoid this ping-pong of
 | 
						|
mitigation by relaxing the mitigation to happen only when the
 | 
						|
temperature goes below this lower hysteresis value.
 | 
						|
 | 
						|
Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
 | 
						|
Signed-off-by: Lina Iyer <ilina@codeaurora.org>
 | 
						|
---
 | 
						|
 drivers/thermal/gov_step_wise.c | 34 ++++++++++++++++++++++++---------
 | 
						|
 1 file changed, 25 insertions(+), 9 deletions(-)
 | 
						|
 | 
						|
diff --git a/drivers/thermal/gov_step_wise.c b/drivers/thermal/gov_step_wise.c
 | 
						|
index cdd3354bc27f..d5097e2cd6cc 100644
 | 
						|
--- a/drivers/thermal/gov_step_wise.c
 | 
						|
+++ b/drivers/thermal/gov_step_wise.c
 | 
						|
@@ -25,7 +25,7 @@
 | 
						|
  *       for this trip point
 | 
						|
  *    d. if the trend is THERMAL_TREND_DROP_FULL, use lower limit
 | 
						|
  *       for this trip point
 | 
						|
- * If the temperature is lower than a trip point,
 | 
						|
+ * If the temperature is lower than a hysteresis temperature,
 | 
						|
  *    a. if the trend is THERMAL_TREND_RAISING, do nothing
 | 
						|
  *    b. if the trend is THERMAL_TREND_DROPPING, use lower cooling
 | 
						|
  *       state for this trip point, if the cooling state already
 | 
						|
@@ -97,7 +97,7 @@ static void update_passive_instance(struct thermal_zone_device *tz,
 | 
						|
 
 | 
						|
 static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
 | 
						|
 {
 | 
						|
-	int trip_temp;
 | 
						|
+	int trip_temp, hyst_temp;
 | 
						|
 	enum thermal_trip_type trip_type;
 | 
						|
 	enum thermal_trend trend;
 | 
						|
 	struct thermal_instance *instance;
 | 
						|
@@ -107,21 +107,37 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
 | 
						|
 	tz->ops->get_trip_temp(tz, trip, &trip_temp);
 | 
						|
 	tz->ops->get_trip_type(tz, trip, &trip_type);
 | 
						|
 
 | 
						|
-	trend = get_tz_trend(tz, trip);
 | 
						|
-
 | 
						|
-	if (tz->temperature >= trip_temp) {
 | 
						|
-		throttle = true;
 | 
						|
-		trace_thermal_zone_trip(tz, trip, trip_type);
 | 
						|
+	tz->ops->get_trip_temp(tz, trip, &trip_temp);
 | 
						|
+	hyst_temp = trip_temp;
 | 
						|
+	if (tz->ops->get_trip_hyst) {
 | 
						|
+		tz->ops->get_trip_hyst(tz, trip, &hyst_temp);
 | 
						|
+		hyst_temp = trip_temp - hyst_temp;
 | 
						|
 	}
 | 
						|
+	tz->ops->get_trip_type(tz, trip, &trip_type);
 | 
						|
 
 | 
						|
-	dev_dbg(&tz->device, "Trip%d[type=%d,temp=%d]:trend=%d,throttle=%d\n",
 | 
						|
-				trip, trip_type, trip_temp, trend, throttle);
 | 
						|
+	trend = get_tz_trend(tz, trip);
 | 
						|
+
 | 
						|
+	dev_dbg(&tz->device,
 | 
						|
+		"Trip%d[type=%d,temp=%d,hyst=%d]:trend=%d,throttle=%d\n",
 | 
						|
+		trip, trip_type, trip_temp, hyst_temp, trend, throttle);
 | 
						|
 
 | 
						|
 	list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
 | 
						|
 		if (instance->trip != trip)
 | 
						|
 			continue;
 | 
						|
 
 | 
						|
 		old_target = instance->target;
 | 
						|
+		throttle = false;
 | 
						|
+		/*
 | 
						|
+		 * Lower the mitigation only if the temperature
 | 
						|
+		 * goes below the hysteresis temperature.
 | 
						|
+		 */
 | 
						|
+		if (tz->temperature >= trip_temp ||
 | 
						|
+		   (tz->temperature >= hyst_temp &&
 | 
						|
+		   old_target != THERMAL_NO_TARGET)) {
 | 
						|
+			throttle = true;
 | 
						|
+			trace_thermal_zone_trip(tz, trip, trip_type);
 | 
						|
+		}
 | 
						|
+
 | 
						|
 		instance->target = get_target_state(instance, trend, throttle);
 | 
						|
 		dev_dbg(&instance->cdev->device, "old_target=%d, target=%d\n",
 | 
						|
 					old_target, (int)instance->target);
 | 
						|
-- 
 | 
						|
2.33.1
 | 
						|
 |