mirror of
https://github.com/Ysurac/openmptcprouter.git
synced 2025-02-15 04:42:02 +00:00
52 lines
2.2 KiB
Diff
52 lines
2.2 KiB
Diff
From d0024cc9b1a63eafca9553cfe44fe282c20da94a Mon Sep 17 00:00:00 2001
|
|
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
|
|
Date: Sun, 16 Oct 2022 09:15:16 +0300
|
|
Subject: [PATCH] media: i2c: imx290: Fix max gain value
|
|
|
|
Upstream commit 6d7a87f2d3a6.
|
|
|
|
The gain is expressed in multiple of 0.3dB, as a value between 0.0dB
|
|
and 72.0dB. Gains between 0.0dB and 30.0dB (included) apply analog gain
|
|
only, higher gains from 30.3dB to 72dB apply additional digital gain.
|
|
|
|
The maximum gain value is erroneously set to 72. Increase it to 100 to
|
|
cover the whole analog gain range. Support for digital gain can be added
|
|
separately if needed.
|
|
|
|
The IMX327 and IMX462 are largely compatible with the IMX290, but have
|
|
an analog gain range of 0.0dB to 29.4dB and 42dB of digital gain. When
|
|
support for those sensors gets added to the driver, the gain control
|
|
should be adjusted accordingly.
|
|
|
|
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
|
|
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
|
|
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
|
|
---
|
|
drivers/media/i2c/imx290.c | 15 ++++++++++++++-
|
|
1 file changed, 14 insertions(+), 1 deletion(-)
|
|
|
|
--- a/drivers/media/i2c/imx290.c
|
|
+++ b/drivers/media/i2c/imx290.c
|
|
@@ -1019,8 +1019,21 @@ static int imx290_probe(struct i2c_clien
|
|
v4l2_ctrl_handler_init(&imx290->ctrls, 5);
|
|
imx290->ctrls.lock = &imx290->lock;
|
|
|
|
+ /*
|
|
+ * The sensor has an analog gain and a digital gain, both controlled
|
|
+ * through a single gain value, expressed in 0.3dB increments. Values
|
|
+ * from 0.0dB (0) to 30.0dB (100) apply analog gain only, higher values
|
|
+ * up to 72.0dB (240) add further digital gain. Limit the range to
|
|
+ * analog gain only, support for digital gain can be added separately
|
|
+ * if needed.
|
|
+ *
|
|
+ * The IMX327 and IMX462 are largely compatible with the IMX290, but
|
|
+ * have an analog gain range of 0.0dB to 29.4dB and 42dB of digital
|
|
+ * gain. When support for those sensors gets added to the driver, the
|
|
+ * gain control should be adjusted accordingly.
|
|
+ */
|
|
v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
|
|
- V4L2_CID_GAIN, 0, 72, 1, 0);
|
|
+ V4L2_CID_GAIN, 0, 100, 1, 0);
|
|
|
|
v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
|
|
V4L2_CID_EXPOSURE, 1, IMX290_VMAX_DEFAULT - 2, 1,
|