mirror of
				https://github.com/Ysurac/openmptcprouter.git
				synced 2025-03-09 15:40:20 +00:00 
			
		
		
		
	
		
			
				
	
	
		
			41 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			41 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From f7006c5786645210a3d47a9b14d2b434e3ecdecf Mon Sep 17 00:00:00 2001
 | 
						|
From: Phil Elwell <phil@raspberrypi.org>
 | 
						|
Date: Tue, 14 Nov 2017 11:03:22 +0000
 | 
						|
Subject: [PATCH 145/277] mcp2515: Use DT-supplied interrupt flags
 | 
						|
 | 
						|
The MCP2515 datasheet clearly describes a level-triggered interrupt
 | 
						|
pin. Therefore the receiving interrupt controller must also be
 | 
						|
configured for level-triggered operation otherwise there is a danger
 | 
						|
of a missed interrupt condition blocking all subsequent interrupts.
 | 
						|
The ONESHOT flag ensures that the interrupt is masked until the
 | 
						|
threaded interrupt handler exits.
 | 
						|
 | 
						|
Rather than change the flags globally (they must have worked for at
 | 
						|
least one user), allow the flags to be overridden from Device Tree
 | 
						|
in the event that the device has a DT node.
 | 
						|
 | 
						|
See: https://github.com/raspberrypi/linux/issues/2175
 | 
						|
     https://github.com/raspberrypi/linux/issues/2263
 | 
						|
 | 
						|
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
 | 
						|
---
 | 
						|
 drivers/net/can/spi/mcp251x.c | 3 +++
 | 
						|
 1 file changed, 3 insertions(+)
 | 
						|
 | 
						|
diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
 | 
						|
index f3f05fea8e1f..6c2d3aba2591 100644
 | 
						|
--- a/drivers/net/can/spi/mcp251x.c
 | 
						|
+++ b/drivers/net/can/spi/mcp251x.c
 | 
						|
@@ -952,6 +952,9 @@ static int mcp251x_open(struct net_device *net)
 | 
						|
 	priv->tx_skb = NULL;
 | 
						|
 	priv->tx_len = 0;
 | 
						|
 
 | 
						|
+	if (spi->dev.of_node)
 | 
						|
+	    flags = 0;
 | 
						|
+
 | 
						|
 	ret = request_threaded_irq(spi->irq, NULL, mcp251x_can_ist,
 | 
						|
 				   flags | IRQF_ONESHOT, DEVICE_NAME, priv);
 | 
						|
 	if (ret) {
 | 
						|
-- 
 | 
						|
2.16.1
 | 
						|
 |