mirror of
				https://github.com/Ysurac/openmptcprouter.git
				synced 2025-03-09 15:40:20 +00:00 
			
		
		
		
	
		
			
				
	
	
		
			47 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			47 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
| From e648de4ec1e8797742d658a897e9355fe093a46c Mon Sep 17 00:00:00 2001
 | |
| From: Matthias Reichl <hias@horus.com>
 | |
| Date: Sat, 9 Sep 2023 13:46:33 +0200
 | |
| Subject: [PATCH] ASoC: hdmi-codec: Fix broken channel map reporting
 | |
| 
 | |
| Commit 4e0871333661 ("ASoC: hdmi-codec: fix channel info for
 | |
| compressed formats") accidentally changed hcp->chmap_idx from
 | |
| ca_id, the CEA channel allocation ID, to idx, the index to
 | |
| the table of channel mappings ordered by preference.
 | |
| 
 | |
| This resulted in wrong channel maps being reported to userspace,
 | |
| eg for 5.1 "FL,FR,LFE,FC" was reported instead of the expected
 | |
| "FL,FR,LFE,FC,RL,RR":
 | |
| 
 | |
| ~ # speaker-test -c 6 -t sine
 | |
| ...
 | |
|  0 - Front Left
 | |
|  3 - Front Center
 | |
|  1 - Front Right
 | |
|  2 - LFE
 | |
|  4 - Unknown
 | |
|  5 - Unknown
 | |
| 
 | |
| ~ # amixer cget iface=PCM,name='Playback Channel Map' | grep ': values'
 | |
|   : values=3,4,8,7,0,0,0,0
 | |
| 
 | |
| Revert this incorrect change so that channel maps are properly
 | |
| reported again.
 | |
| 
 | |
| Fixes: 4e0871333661 ("ASoC: hdmi-codec: fix channel info for compressed formats")
 | |
| Cc: stable@vger.kernel.org
 | |
| Signed-off-by: Matthias Reichl <hias@horus.com>
 | |
| ---
 | |
|  sound/soc/codecs/hdmi-codec.c | 2 +-
 | |
|  1 file changed, 1 insertion(+), 1 deletion(-)
 | |
| 
 | |
| --- a/sound/soc/codecs/hdmi-codec.c
 | |
| +++ b/sound/soc/codecs/hdmi-codec.c
 | |
| @@ -520,7 +520,7 @@ static int hdmi_codec_fill_codec_params(
 | |
|  	hp->sample_rate = sample_rate;
 | |
|  	hp->channels = channels;
 | |
|  
 | |
| -	hcp->chmap_idx = idx;
 | |
| +	hcp->chmap_idx = ca_id;
 | |
|  
 | |
|  	return 0;
 | |
|  }
 |