mirror of
				https://github.com/Ysurac/openmptcprouter.git
				synced 2025-03-09 15:40:20 +00:00 
			
		
		
		
	
		
			
				
	
	
		
			41 lines
		
	
	
	
		
			1.6 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			41 lines
		
	
	
	
		
			1.6 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
| From 6c245411748fd2ded08558ac97626d1baf337cb3 Mon Sep 17 00:00:00 2001
 | ||
| From: Nathan Chancellor <natechancellor@gmail.com>
 | ||
| Date: Sun, 4 Mar 2018 17:20:25 -0700
 | ||
| Subject: [PATCH 125/432] sound: bcm: Fix memset dereference warning
 | ||
| MIME-Version: 1.0
 | ||
| Content-Type: text/plain; charset=UTF-8
 | ||
| Content-Transfer-Encoding: 8bit
 | ||
| 
 | ||
| This warning appears with GCC 6.4.0 from toolchains.bootlin.com:
 | ||
| 
 | ||
| ../sound/soc/bcm/allo-piano-dac-plus.c: In function ‘snd_allo_piano_dac_init’:
 | ||
| ../sound/soc/bcm/allo-piano-dac-plus.c:711:30: warning: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
 | ||
|   memset(glb_ptr, 0x00, sizeof(glb_ptr));
 | ||
|                               ^
 | ||
| 
 | ||
| Suggested-by: Phil Elwell <phil@raspberrypi.org>
 | ||
| Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
 | ||
| ---
 | ||
|  sound/soc/bcm/allo-piano-dac-plus.c | 3 +--
 | ||
|  1 file changed, 1 insertion(+), 2 deletions(-)
 | ||
| 
 | ||
| diff --git a/sound/soc/bcm/allo-piano-dac-plus.c b/sound/soc/bcm/allo-piano-dac-plus.c
 | ||
| index d35e0553a763..35d77e905fdf 100644
 | ||
| --- a/sound/soc/bcm/allo-piano-dac-plus.c
 | ||
| +++ b/sound/soc/bcm/allo-piano-dac-plus.c
 | ||
| @@ -706,11 +706,10 @@ static int snd_allo_piano_dac_init(struct snd_soc_pcm_runtime *rtd)
 | ||
|  	struct snd_soc_card *card = rtd->card;
 | ||
|  	struct glb_pool *glb_ptr;
 | ||
|  
 | ||
| -	glb_ptr = kmalloc(sizeof(struct glb_pool), GFP_KERNEL);
 | ||
| +	glb_ptr = kzalloc(sizeof(struct glb_pool), GFP_KERNEL);
 | ||
|  	if (!glb_ptr)
 | ||
|  		return -ENOMEM;
 | ||
|  
 | ||
| -	memset(glb_ptr, 0x00, sizeof(glb_ptr));
 | ||
|  	card->drvdata = glb_ptr;
 | ||
|  	glb_ptr->dual_mode = 2;
 | ||
|  	glb_ptr->set_mode = 0;
 | ||
| -- 
 | ||
| 2.19.1
 | ||
| 
 |