mirror of
				https://github.com/Ysurac/openmptcprouter.git
				synced 2025-03-09 15:40:20 +00:00 
			
		
		
		
	
		
			
				
	
	
		
			59 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			59 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From c35416dd769df2007b7670f2b6676f2d2825c551 Mon Sep 17 00:00:00 2001
 | 
						|
From: Maxime Ripard <maxime@cerno.tech>
 | 
						|
Date: Mon, 21 Nov 2022 13:33:37 +0100
 | 
						|
Subject: [PATCH] drm/tests: helpers: Switch to a platform_device
 | 
						|
MIME-Version: 1.0
 | 
						|
Content-Type: text/plain; charset=UTF-8
 | 
						|
Content-Transfer-Encoding: 8bit
 | 
						|
 | 
						|
The device managed resources are ran if the device has bus, which is not
 | 
						|
the case of a root_device.
 | 
						|
 | 
						|
Let's use a platform_device instead.
 | 
						|
 | 
						|
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
 | 
						|
Reviewed-by: Maíra Canal <mcanal@igalia.com>
 | 
						|
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
 | 
						|
---
 | 
						|
 drivers/gpu/drm/tests/drm_kunit_helpers.c | 16 ++++++++++++++--
 | 
						|
 1 file changed, 14 insertions(+), 2 deletions(-)
 | 
						|
 | 
						|
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
 | 
						|
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
 | 
						|
@@ -7,6 +7,7 @@
 | 
						|
 #include <kunit/resource.h>
 | 
						|
 
 | 
						|
 #include <linux/device.h>
 | 
						|
+#include <linux/platform_device.h>
 | 
						|
 
 | 
						|
 #define KUNIT_DEVICE_NAME	"drm-kunit-mock-device"
 | 
						|
 
 | 
						|
@@ -32,7 +33,16 @@ static const struct drm_mode_config_func
 | 
						|
  */
 | 
						|
 struct device *drm_kunit_helper_alloc_device(struct kunit *test)
 | 
						|
 {
 | 
						|
-	return root_device_register(KUNIT_DEVICE_NAME);
 | 
						|
+	struct platform_device *pdev;
 | 
						|
+	int ret;
 | 
						|
+
 | 
						|
+	pdev = platform_device_alloc(KUNIT_DEVICE_NAME, PLATFORM_DEVID_NONE);
 | 
						|
+	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev);
 | 
						|
+
 | 
						|
+	ret = platform_device_add(pdev);
 | 
						|
+	KUNIT_ASSERT_EQ(test, ret, 0);
 | 
						|
+
 | 
						|
+	return &pdev->dev;
 | 
						|
 }
 | 
						|
 EXPORT_SYMBOL_GPL(drm_kunit_helper_alloc_device);
 | 
						|
 
 | 
						|
@@ -45,7 +55,9 @@ EXPORT_SYMBOL_GPL(drm_kunit_helper_alloc
 | 
						|
  */
 | 
						|
 void drm_kunit_helper_free_device(struct kunit *test, struct device *dev)
 | 
						|
 {
 | 
						|
-	root_device_unregister(dev);
 | 
						|
+	struct platform_device *pdev = to_platform_device(dev);
 | 
						|
+
 | 
						|
+	platform_device_unregister(pdev);
 | 
						|
 }
 | 
						|
 EXPORT_SYMBOL_GPL(drm_kunit_helper_free_device);
 | 
						|
 
 |