public/coins-demo
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Prevent occasional crash during task re-ordering

Browse source 
Prevent occasional crash during task re-ordering
This commit is contained in:
Scot Hacker 2019-03-25 07:45:26 -07:00 • committed by GitHub
parent f6d79879ae
commit 184084c6a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
todo/views/reorder_tasks.py
View file

@ -20,10 +20,15 @@ def reorder_tasks(request) -> HttpResponse:
# Re-prioritize each task in list # Re-prioritize each task in list
i = 1 i = 1
for id in newtasklist: for id in newtasklist:
task = Task.objects.get(pk=id) try:
task.priority = i task = Task.objects.get(pk=id)
task.save() task.priority = i
i += 1 task.save()
i += 1
except Task.DoesNotExist:
# Can occur if task is deleted behind the scenes during re-ordering.
# Not easy to remove it from the UI without page refresh, but prevent crash.
pass
# All views must return an httpresponse of some kind ... without this we get # All views must return an httpresponse of some kind ... without this we get
# error 500s in the log even though things look peachy in the browser. # error 500s in the log even though things look peachy in the browser.