Prevent occasional crash during task re-ordering

Prevent occasional crash during task re-ordering
This commit is contained in:
Scot Hacker 2019-03-25 07:45:26 -07:00 committed by GitHub
parent f6d79879ae
commit 184084c6a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -20,10 +20,15 @@ def reorder_tasks(request) -> HttpResponse:
# Re-prioritize each task in list
i = 1
for id in newtasklist:
try:
task = Task.objects.get(pk=id)
task.priority = i
task.save()
i += 1
except Task.DoesNotExist:
# Can occur if task is deleted behind the scenes during re-ordering.
# Not easy to remove it from the UI without page refresh, but prevent crash.
pass
# All views must return an httpresponse of some kind ... without this we get
# error 500s in the log even though things look peachy in the browser.