public/coins-demo
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix / improve notification email subjects and bodies

Browse source
This commit is contained in:
Scot Hacker 2018-04-08 23:32:52 -07:00
parent 5805cf52ad
commit 782950d904
4 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
todo/templates/todo/email/assigned_body.txt
View file

@ -1,6 +1,6 @@
{{ task.assigned_to.first_name }} - {{ task.assigned_to.first_name }} -
A new task on the list {{ task.task_list.name }} has been assigned to you by {{ task.created_by.get_full_name }: A new task on the list {{ task.task_list.name }} has been assigned to you by {{ task.created_by.get_full_name }}:
{{ task.title }} {{ task.title }}

2
todo/templates/todo/email/assigned_subject.txt
View file

@ -1 +1 @@
GTD: New task - {% autoescape off %}Note: {{ task.title }}{% endautoescape %} A new task has been assigned to you - {% autoescape off %}{{ task.title }}{% endautoescape %}

4
todo/utils.py
View file

@ -21,11 +21,11 @@ def send_notify_mail(new_task):
[new_task.assigned_to.email], fail_silently=False) [new_task.assigned_to.email], fail_silently=False)
def send_email_to_thread_participants(task, msg_body, user): def send_email_to_thread_participants(task, msg_body, user, subject=None):
# Notify all previous commentors on a Task about a new comment. # Notify all previous commentors on a Task about a new comment.
current_site = Site.objects.get_current() current_site = Site.objects.get_current()
email_subject = render_to_string("todo/email/assigned_subject.txt", {'task': task}) email_subject = subject if subject else render_to_string("todo/email/assigned_subject.txt", {'task': task})
email_body = render_to_string( email_body = render_to_string(
"todo/email/newcomment_body.txt", "todo/email/newcomment_body.txt",
{'task': task, 'body': msg_body, 'site': current_site, 'user': user} {'task': task, 'body': msg_body, 'site': current_site, 'user': user}

4
todo/views.py
View file

@ -200,7 +200,9 @@ def task_detail(request, task_id: int) -> HttpResponse:
body=request.POST['comment-body'], body=request.POST['comment-body'],
) )
send_email_to_thread_participants(task, request.POST['comment-body'], request.user) send_email_to_thread_participants(
task, request.POST['comment-body'], request.user,
subject='New comment posted on task "{}"'.format(task.title))
messages.success(request, "Comment posted. Notification email sent to thread participants.") messages.success(request, "Comment posted. Notification email sent to thread participants.")
# Save task edits # Save task edits