public/mailtrain
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixed a bunch of MySQL pooling issues where connections were not properly released or were double-released

Browse source
This commit is contained in:
Andris Reinman 2016-04-05 15:29:42 +03:00
parent 06d2712916
commit 0392473ecd
8 changed files with 10 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/models/fields.js
View file

@ -328,11 +328,11 @@ function addCustomField(listId, name, defaultValue, type, group, visible, callba
}
connection.query(query, err => {
connection.release();
if (err) {
connection.query('DELETE FROM custom_fields WHERE id=? LIMIT 1', [fieldId], () => false);
connection.query('DELETE FROM custom_fields WHERE id=? LIMIT 1', [fieldId], () => connection.release());
return callback(err);
}
connection.release();
return callback(null, fieldId);
});
});