Removed obsolete dir

Numeric conversions for all ids coming in as route req params.
Infrastructure for proper error message when dependencies prevent entity deletion.

lib/file-helpers.js

@@ -5,6 +5,7 @@ const files = require('../models/files');
 
 const path = require('path');
 const uploadedFilesDir = path.join(files.filesDir, 'uploaded');
+const {castToInteger} = require('./helpers');
 
 const multer = require('multer')({
     dest: uploadedFilesDir
@@ -12,7 +13,7 @@ const multer = require('multer')({
 
 function installUploadHandler(router, url, replacementBehavior, type, subType) {
     router.postAsync(url, passport.loggedIn, multer.array('files[]'), async (req, res) => {
-        return res.json(await files.createFiles(req.context, type || req.params.type, subType || req.params.subType, req.params.entityId, req.files, replacementBehavior));
+        return res.json(await files.createFiles(req.context, type || req.params.type, subType || req.params.subType, castToInteger(req.params.entityId), req.files, replacementBehavior));
     });
 }
 

lib/helpers.js

@@ -5,7 +5,8 @@ let _ = require('./translate')._;
 module.exports = {
     enforce,
     cleanupFromPost,
-    filterObject
+    filterObject,
+    castToInteger
 };
 
 function enforce(condition, message) {
@@ -27,4 +28,14 @@ function filterObject(obj, allowedKeys) {
     }
 
     return result;
+}
+
+function castToInteger(id) {
+    const val = parseInt(id);
+
+    if (!Number.isInteger(val)) {
+        throw new Error('Invalid id');
+    }
+
+    return val;
 }