public/mailtrain
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #687 from Charlo270398/development-LDAPfirstLogin

Browse source 
LDAP - Users not created on the fly upon first login fixed #683 (good one)
This commit is contained in:
Tomas Bures 2019-08-21 14:43:58 +02:00 • committed by GitHub
commit af2e988ae7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
server/lib/passport.js
View file

@ -187,15 +187,15 @@ if (LdapStrategy) {
return { return {
id: user.id, id: user.id,
username: user.username, username: profile[config.ldap.uidTag],
name: profile[config.ldap.nameTag], name: profile[config.ldap.nameTag],
email: profile.mail, email: profile[config.ldap.mailTag],
role: user.role role: user.role
}; };
} catch (err) { } catch (err) {
if (err instanceof interoperableErrors.NotFoundError) { if (err instanceof interoperableErrors.NotFoundError) {
const userId = await users.create(null, { const userId = await users.create(contextHelpers.getAdminContext(), {
username: profile[config.ldap.uidTag], username: profile[config.ldap.uidTag],
role: config.ldap.newUserRole, role: config.ldap.newUserRole,
namespace: config.ldap.newUserNamespaceId namespace: config.ldap.newUserNamespaceId
@ -205,7 +205,7 @@ if (LdapStrategy) {
id: userId, id: userId,
username: profile[config.ldap.uidTag], username: profile[config.ldap.uidTag],
name: profile[config.ldap.nameTag], name: profile[config.ldap.nameTag],
email: profile.mail, email: profile[config.ldap.mailTag],
role: config.ldap.newUserRole role: config.ldap.newUserRole
}; };
} else { } else {

6
server/models/users.js
View file

@ -258,7 +258,11 @@ async function getByAccessToken(accessToken) {
} }
async function getByUsername(username) { async function getByUsername(username) {
return await _getBy(contextHelpers.getAdminContext(), 'username', username); try{
return await _getBy(contextHelpers.getAdminContext(), 'username', username);
}catch(err){
throw new interoperableErrors.NotFoundError();
}
} }
async function getByUsernameIfPasswordMatch(context, username, password) { async function getByUsernameIfPasswordMatch(context, username, password) {